Change trigger branch. Add RC by printminion-co · Pull Request #201 · IONOS-Productivity/ncw-server

printminion-co · 2026-01-26T16:54:09Z

Summary

This pull request updates the GitHub Actions workflow in .github/workflows/build-artifact.yml to add support for release candidate (rc/*) branches, improve concurrency handling, and enhance artifact storage and remote trigger logic. These changes make the CI/CD pipeline more flexible and robust, especially for managing release candidate builds alongside existing development and stable workflows.

Support for rc/ branches and improved workflow logic:*

Added rc/** to the list of branches that trigger the workflow, and updated branch validation logic to accept ionos-dev, ionos-stable, and any rc/* branch. [1] [2]
Updated concurrency group logic to ensure unique and descriptive concurrency keys for PRs, main branches, and rc/* branches, preventing collisions and ensuring correct workflow cancellation.

Artifact upload and storage enhancements:

Improved artifact path structure in the Artifactory upload step to support rc/* branches, and clarified the storage logic for PRs, dev, stable, and rc builds. The artifact paths now include version and short SHA for better traceability. [1] [2]

Branch/Event	Stage Prefix	Artifact Path
Pull Request	dev	dev/pr/nextcloud-workspace-pr-.zip
ionos-dev	dev	dev/ncw-//nextcloud-workspace-.zip
ionos-stable	stable	stable/ncw-//nextcloud-workspace-.zip
rc/*	rc	rc/<github.ref_name>/ncw-//nextcloud-workspace-.zip

Remote workflow trigger improvements:

Extended remote workflow trigger to include rc/* branches, added prerequisite checks for required variables and secrets, and mapped all branches to the correct build type (dev, stable, rc) for remote triggering.
Standardized the GitLab trigger to always use ref="main" regardless of branch, ensuring consistency in remote build invocation.

TODO

Test PR on push to rc/* branch. e.g. https://github.com/IONOS-Productivity/ncw-server/tree/refs/heads/rc/tmp-01
- Observe: artifact is build on proper location
- Observe: image pipeline is triggered with proper parameter

Checklist

Code is properly formatted
Sign-off message is added to all commits
Tests (unit, integration, api and/or acceptance) are included
Screenshots before/after for front-end changes
Documentation (manuals or wiki) has been updated or is not required
Backports requested where applicable (ex: critical bugfixes)

Copilot

Pull request overview

This PR enhances the GitHub Actions workflow to support release candidate branches by adding rc/** branch pattern support for automated builds and remote workflow triggers.

Changes:

Added rc/** branch pattern to workflow push triggers
Updated remote workflow trigger conditions to include rc/* branches
Modified build type determination to map rc/* branches to rc build type and standardized GitLab reference to main for all branch types

.github/workflows/build-artifact.yml

Copilot

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.

.github/workflows/build-artifact.yml

printminion-co · 2026-01-27T10:37:31Z

@copilot open a new pull request to apply changes based on the comments in this thread

Copilot · 2026-01-27T10:37:43Z

@printminion-co I've opened a new pull request, #205, to work on those changes. Once the pull request is ready, I'll request review from you.

Copilot

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.

.github/workflows/build-artifact.yml

Copilot

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.

.github/workflows/build-artifact.yml

printminion-co · 2026-01-27T13:53:58Z

@copilot open a new pull request to apply changes based on the comments in this thread

Copilot · 2026-01-27T13:54:08Z

@printminion-co I've opened a new pull request, #207, to work on those changes. Once the pull request is ready, I'll request review from you.

Improve clarity and maintainability by restructuring the branch type to GitLab BUILD_TYPE mapping. Add inline documentation table showing the complete mapping for all supported branch patterns (ionos-dev, ionos-stable, rc/*, and pull requests). Signed-off-by: Misha M.-Kupriyanov <kupriyanov@strato.de>

Convert single-line branch validation condition into multi-line format to improve readability and prepare for future extensions to support additional branch patterns. Signed-off-by: Misha M.-Kupriyanov <kupriyanov@strato.de>

Convert single-line concurrency group definition to multi-line YAML format for improved readability. No functional changes. Signed-off-by: Misha M.-Kupriyanov <kupriyanov@strato.de>

Update concurrency group to use github.head_ref with ref_name fallback instead of ref. This provides better isolation for pull request builds while maintaining compatibility with branch builds. Signed-off-by: Misha M.-Kupriyanov <kupriyanov@strato.de>

Enable automatic cancellation of in-progress workflow runs when new commits are pushed to the same branch or pull request. This prevents redundant builds and saves CI resources. Signed-off-by: Misha M.-Kupriyanov <kupriyanov@strato.de>

Add pull_request event type to branch validation condition, enabling the workflow to run on PRs targeting ionos-dev, ionos-stable, and rc/* branches. Update validation error message to reflect PR support. Signed-off-by: Misha M.-Kupriyanov <kupriyanov@strato.de>

Copilot

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.

.github/workflows/build-artifact.yml

As requested by target repo team

Copilot

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.

.github/workflows/build-artifact.yml

Add full CI/CD pipeline support for release candidate (rc/*) branches across all workflow stages: Workflow Triggers: - Add 'rc/**' pattern to push trigger branches - Update concurrency group to prevent rc/* builds from interfering Branch Validation: - Extend configuration check to recognize rc/* as valid trigger branch - Update validation messages to include rc/* in expected patterns Artifactory Integration: - Enable artifact upload for rc/* branches - Create separate 'rc/*' directory for rc/* build artifacts - Set ARTIFACTORY_STAGE_PREFIX='rc' for proper organization GitLab Pipeline Integration: - Set BUILD_TYPE='rc' for rc/* branch builds - Update trigger conditions to include rc/* branches - Add rc/* to branch-to-GitLab mapping documentation table This provides complete parity with ionos-dev and ionos-stable branches, enabling proper release candidate workflow with isolated artifacts. Signed-off-by: Misha M.-Kupriyanov <kupriyanov@strato.de>

Update concurrency group definition to use github.event.number for pull requests. This ensures each PR gets its own concurrency group, preventing PRs from canceling each other's builds while still allowing new commits to the same PR to cancel previous runs. Signed-off-by: Misha M.-Kupriyanov <kupriyanov@strato.de>

Add comprehensive validation before triggering remote GitLab workflow: Dependency Management: - Add build-artifact to needs array to ensure NC_VERSION output is available - Update if condition to verify both build-artifact and upload-to-artifactory succeeded Variable Validation: - Validate secrets (GITLAB_TOKEN, GITLAB_TRIGGER_URL) - Validate job outputs (NC_VERSION, ARTIFACTORY_LAST_BUILD_PATH) - Validate GitHub context variables (sha, run_id, ref_name) - Abort with error if any required variable is missing This prevents the remote workflow from being triggered with missing critical variables like NC_VERSION, which was previously not available because build-artifact was not in the needs array. Signed-off-by: Misha M.-Kupriyanov <kupriyanov@strato.de>

Update trigger-remote-dev-workflow to target the main branch in GitLab for all branch types (ionos-dev, ionos-stable, rc/*) instead of 'stable'. This represents a behavioral change for ionos-stable branch: it now triggers GitLab builds with ref="main" instead of ref="stable". This aligns with the GitLab repository structure where main is the target branch for container image builds across all branch types. Signed-off-by: Misha M.-Kupriyanov <kupriyanov@strato.de>

lara-fernandezcueto · 2026-01-28T08:49:49Z

LGTM

printminion-co requested a review from Copilot January 26, 2026 16:54

Copilot AI reviewed Jan 26, 2026

View reviewed changes

.github/workflows/build-artifact.yml Outdated Show resolved Hide resolved

printminion-co force-pushed the mk/dev/change_trigger_branch branch 2 times, most recently from ea53e5f to 58949f4 Compare January 27, 2026 10:17

printminion-co changed the title ~~Mk/dev/change trigger branch~~ Change trigger branch. Add RC Jan 27, 2026

printminion-co force-pushed the mk/dev/change_trigger_branch branch 2 times, most recently from fc803cf to 2583fb8 Compare January 27, 2026 10:34

printminion-co requested a review from Copilot January 27, 2026 10:35

Copilot AI reviewed Jan 27, 2026

View reviewed changes

.github/workflows/build-artifact.yml Outdated Show resolved Hide resolved

.github/workflows/build-artifact.yml Outdated Show resolved Hide resolved

Copilot AI mentioned this pull request Jan 27, 2026

Fix inconsistent pattern matching syntax for rc/* branches #205

Merged

5 tasks

printminion-co added this to the ncw-3 milestone Jan 27, 2026

printminion-co force-pushed the mk/dev/change_trigger_branch branch from f5a36c5 to e8114f2 Compare January 27, 2026 10:47

printminion-co requested a review from Copilot January 27, 2026 10:50

Copilot AI reviewed Jan 27, 2026

View reviewed changes

.github/workflows/build-artifact.yml Outdated Show resolved Hide resolved

printminion-co requested a review from Copilot January 27, 2026 11:21

Copilot AI reviewed Jan 27, 2026

View reviewed changes

.github/workflows/build-artifact.yml Outdated Show resolved Hide resolved

.github/workflows/build-artifact.yml Outdated Show resolved Hide resolved

printminion-co force-pushed the mk/dev/change_trigger_branch branch from 7fa1b59 to 1f4bb38 Compare January 27, 2026 13:32

Copilot AI mentioned this pull request Jan 27, 2026

Refactor workflow concurrency group and consolidate branch validation #207

Draft

7 tasks

printminion-co force-pushed the mk/dev/change_trigger_branch branch from 1f4bb38 to 2efca8f Compare January 27, 2026 15:29

printminion-co added 6 commits January 27, 2026 16:37

IONOS(ci): Refactor branch validation into multi-line format

35c259a

Convert single-line branch validation condition into multi-line format to improve readability and prepare for future extensions to support additional branch patterns. Signed-off-by: Misha M.-Kupriyanov <kupriyanov@strato.de>

IONOS(ci): Refactor concurrency group into multi-line YAML format

ff7cdb7

Convert single-line concurrency group definition to multi-line YAML format for improved readability. No functional changes. Signed-off-by: Misha M.-Kupriyanov <kupriyanov@strato.de>

printminion-co force-pushed the mk/dev/change_trigger_branch branch from 2efca8f to 958ff8a Compare January 27, 2026 15:42

printminion-co force-pushed the mk/dev/change_trigger_branch branch from 958ff8a to 2dacc4b Compare January 27, 2026 15:43

printminion-co requested a review from Copilot January 27, 2026 15:45

Copilot AI reviewed Jan 27, 2026

View reviewed changes

.github/workflows/build-artifact.yml Show resolved Hide resolved

.github/workflows/build-artifact.yml Outdated Show resolved Hide resolved

IONOS(ci): Change GitLab ref from 'stable' to 'main' for branch builds

7ce7479

As requested by target repo team

printminion-co force-pushed the mk/dev/change_trigger_branch branch from 2dacc4b to d1d3c33 Compare January 27, 2026 15:59

printminion-co requested a review from Copilot January 27, 2026 15:59

Copilot AI reviewed Jan 27, 2026

View reviewed changes

.github/workflows/build-artifact.yml Show resolved Hide resolved

.github/workflows/build-artifact.yml Show resolved Hide resolved

printminion-co force-pushed the mk/dev/change_trigger_branch branch from d1d3c33 to d3079aa Compare January 27, 2026 16:34

printminion-co added 4 commits January 27, 2026 17:42

printminion-co force-pushed the mk/dev/change_trigger_branch branch from d3079aa to d00793e Compare January 27, 2026 16:45

printminion-co merged commit a0e7c2d into rc/nsw-3 Jan 28, 2026
17 of 24 checks passed

Comments

Conversation

printminion-co commented Jan 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

TODO

Checklist

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

printminion-co commented Jan 27, 2026

Uh oh!

Copilot AI commented Jan 27, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

printminion-co commented Jan 27, 2026

Uh oh!

Copilot AI commented Jan 27, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

lara-fernandezcueto commented Jan 28, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

printminion-co commented Jan 26, 2026 •

edited

Loading